Fix TypeScript declarations #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will indeed work aronud the problems arisen through feathersjs/feathers#692 and feathersjs-ecosystem/feathers-hooks#173. It will basically have undone #69 on all packages. Which isn't too bad because we'd actually need This is a nightmare. |
|
tests fail due to #77 |
|
Test fixed in #79. Will release this shortly, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript declarations are inconsistent between packages. Compiling throws an error
All declarations of 'Service' must have identical type parameters.There were 2 separate changes in
Servicedeclaration:Most recent change didn't update this package.
Linking feathersjs-ecosystem/feathers-hooks#172 as well for possible future search of this problem.