Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to shared feathers-service-tests suite #4

Merged
merged 1 commit into from
Nov 8, 2015
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Nov 3, 2015

This uses the shared test suite at https://github.com/feathersjs/feathers-service-tests. It looks like two tests are failing. @ekryski or @marshallswain maybe you can have a look?

@daffl
Copy link
Member Author

daffl commented Nov 3, 2015

Specifically $select and $not. I think $select just has the wrong format (it is tested against an array now) and it looks like NeDB doesn't support $not (which is odd because it is in the documentation).

@ekryski
Copy link
Member

ekryski commented Nov 3, 2015

I can take a look this afternoon most likely. I passed out early last night so I'll be hammering pretty hard on Feathers today. 😴

@daffl
Copy link
Member Author

daffl commented Nov 4, 2015

Ok should be fixed now. I had to update the tests for $not and submit a PR for feathers-knex.

@daffl
Copy link
Member Author

daffl commented Nov 7, 2015

So the tests for $not were actually what $ne is supposed to do. This one should be good to go now except for the updated documentation that I am currently working on.

daffl added a commit that referenced this pull request Nov 8, 2015
Migrating to shared feathers-service-tests suite
@daffl daffl merged commit 6424b7b into master Nov 8, 2015
@daffl daffl deleted the service-tests branch November 8, 2015 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants