Fix id extraction in id #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KidkArolis
force-pushed
the
fix-create
branch
from
1917feb
to
cc8fd37
Compare
|
I've updated this PR to unbreak the sqlite support. |
KidkArolis
commented
Dec 17, 2020
| id = rows[0][this.id] | ||
| } | ||
|
|
||
| if (!id) return rows |
There was a problem hiding this comment.
Not 100% sure about this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In knex, db.insert(data, ['id']) returns an array of objects in the shape of [{ id }, { id }]. Referencing
rows[0]gives you{ id }, and that means we callthis._get({ id }), when we meant to callthis._get(id). This still works! Because of knexify manages to turn that into a valid query, but I'm not sure that's intended? We just want to call_get(id)from the get go. This doesn't really change the outcome, but confused me for a while when debugging another issue, and this change could prevent future problems in casefeathers-knexorknexcode changes in some way.