Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing count default sort #151

Merged
merged 6 commits into from
Mar 26, 2018
Merged

Fixing count default sort #151

merged 6 commits into from
Mar 26, 2018

Conversation

jerfowler
Copy link
Contributor

Summary

Fixes issues with #141 and a few other small issues.

  • Clones params.knex so the default orderBy doesn't cause an error when counting
  • Creates a test scenario for customized params.knex so this doesn't break in the future
  • Fixes rollback hook so the error information is not [undefined]
  • Fixes documentation on customized queries

@daffl
Copy link
Member

daffl commented Mar 26, 2018

This is great, thank you!

@daffl daffl merged commit cd84f45 into feathersjs-ecosystem:master Mar 26, 2018
@daffl
Copy link
Member

daffl commented Mar 26, 2018

Released as v3.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerfowler @daffl