Properly support null values used within WHERE conditions. (#127)

* Properly support null values used within WHERE conditions.

* Made new NULL where condition test not rely on specific result ordering.

* Make another  NULL where condition test not rely on specific result ordering.

src/index.js

@@ -103,7 +103,7 @@ class Service {
         return query[method].call(query, column, value);
       }
 
-      return query.where(column, operator, value);
+      return operator === '=' ? query.where(column, value) : query.where(column, operator, value);
     });
   }
 

test/index.test.js

@@ -141,6 +141,114 @@ describe('Feathers Knex Service', () => {
         app.service('/people').remove(null);
       });
     });
+
+    it('where conditions support NULL values properly', () => {
+      app.service('/people').create([{
+        name: 'Dave without age',
+        age: null
+      }, {
+        name: 'Dave',
+        age: 32
+      }, {
+        name: 'Dada',
+        age: 1
+      }]);
+
+      return app.service('/people').find({
+        query: {
+          age: null
+        }
+      }).then(data => {
+        expect(data.length).to.equal(1);
+        expect(data[0].name).to.be.equal('Dave without age');
+        expect(data[0].age).to.be.equal(null);
+        app.service('/people').remove(null);
+      });
+    });
+
+    it('where conditions support NOT NULL case properly', () => {
+      app.service('/people').create([{
+        name: 'Dave without age',
+        age: null
+      }, {
+        name: 'Dave',
+        age: 32
+      }, {
+        name: 'Dada',
+        age: 1
+      }]);
+
+      return app.service('/people').find({
+        query: {
+          age: {$ne: null}
+        }
+      }).then(data => {
+        expect(data.length).to.equal(2);
+        expect(data[0].name).to.not.be.equal('Dave without age');
+        expect(data[0].age).to.not.be.equal(null);
+        expect(data[1].name).to.not.be.equal('Dave without age');
+        expect(data[1].age).to.not.be.equal(null);
+        app.service('/people').remove(null);
+      });
+    });
+
+    it('where conditions support NULL values within AND conditions', () => {
+      app.service('/people').create([{
+        name: 'Dave',
+        age: null
+      }, {
+        name: 'Dave',
+        age: 32
+      }, {
+        name: 'Dada',
+        age: 1
+      }]);
+
+      return app.service('/people').find({
+        query: {
+          age: null,
+          name: 'Dave'
+        }
+      }).then(data => {
+        expect(data.length).to.equal(1);
+        expect(data[0].name).to.be.equal('Dave');
+        expect(data[0].age).to.be.equal(null);
+        app.service('/people').remove(null);
+      });
+    });
+
+    it('where conditions support NULL values within OR conditions', () => {
+      app.service('/people').create([{
+        name: 'Dave without age',
+        age: null
+      }, {
+        name: 'Dave',
+        age: 32
+      }, {
+        name: 'Dada',
+        age: 1
+      }]);
+
+      return app.service('/people').find({
+        query: {
+          $or: [
+            {
+              age: null
+            },
+            {
+              name: 'Dada'
+            }
+          ]
+        }
+      }).then(data => {
+        expect(data.length).to.equal(2);
+        expect(data[0].name).not.be.equal('Dave');
+        expect(data[0].age).not.be.equal(32);
+        expect(data[1].name).not.be.equal('Dave');
+        expect(data[1].age).not.be.equal(32);
+        app.service('/people').remove(null);
+      });
+    });
   });
 });