Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Add ability to delete deeply nested attributes in bundled hooks #84

Merged
merged 3 commits into from
Jul 7, 2016
Merged

Conversation

ryuken
Copy link
Contributor

@ryuken ryuken commented Jul 4, 2016

Issue #79 asked for the ability to delete deeply nested attributes in a bundled hook like:

hooks.remove("user.password")

I added functionality which checks if the object has the field.
And also a separate function to remove the field

I needed this for myself so I thought I could share and also get a review on my code

@daffl
Copy link
Member

daffl commented Jul 6, 2016

Thank you, that makes sense. Could you add a test for this in https://github.com/feathersjs/feathers-hooks/blob/master/test/bundled.test.js#L113?

@daffl daffl merged commit fb946ae into feathersjs-ecosystem:master Jul 7, 2016
@daffl
Copy link
Member

daffl commented Jul 7, 2016

Awesome! It will go into the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants