This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Refactoring hooks to run before event dispatching #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 works great! The only thing I noticed is that you have to return data from a filter. It's not like hooks where you can just return nothing and they'll still work but that's an issue for socket-commons.
|
ekryski
added a commit
that referenced
this pull request
Mar 6, 2016
Refactoring hooks to run before event dispatching
This was referenced Mar 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for feathersjs/feathers#248 and solves it specifically when using hooks by pushing it before all other mixins. This also allowed to refactor hooks processing itself into a smaller and more straightforward module.