This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Adds the app object at hook.app. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only changes in before.js are at line 4 where it's all wrapped in a function in order to pass in the app, and line 26 where it adds |
|
Looks pretty good. Do you think we need the same thing in the |
I think this is the most elegant place to add the app object so that it's always available, even on internal requests that don't pass through one of the providers. The next issue that will surface is probably circular requests where service A requests data from B, B from C, and C from A.
marshallswain
force-pushed
the
make-app-available-in-hooks
branch
from
b3475d1
to
4f18aed
Compare
|
I actually started doing that, then noticed that the hookObject gets copied from the before hooks to the after hooks. I've added a test to make sure the app object is present in afterHooks. |
marshallswain
added a commit
that referenced
this pull request
Jan 23, 2016
Adds the app object at hook.app.
|
Where is the documentation? ;) |
|
Good point! I'll get that added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the most elegant place to add the app object so that it's always available in hooks, even on internal requests (which don't pass through one of the providers).
The next issue that will surface is probably circular requests where service A requests data from B, B from C, and C from A.