Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

[typings] add service and id to hook context object #169

Merged
merged 3 commits into from
Sep 25, 2017

Conversation

j2L4e
Copy link
Contributor

@j2L4e j2L4e commented Sep 24, 2017

Summary

(If you have not already please refer to the contributing guideline as described
here
)

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
  • Is this PR dependent on PRs in other repos?

If so, please mention them to keep the conversations linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.

If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.

Thanks for contributing to Feathers! ❤️

@j2L4e j2L4e mentioned this pull request Sep 25, 2017
index.d.ts Outdated
service?: Service<T>;

// server side only
id?: string;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Service is outside this namespace, I think it should be feathers.Service<T>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

@daffl daffl merged commit 3762607 into feathersjs-ecosystem:master Sep 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants