Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hand-flat.svg #836

Closed
wants to merge 2 commits into from
Closed

Create hand-flat.svg #836

wants to merge 2 commits into from

Conversation

drinking-code
Copy link
Contributor

@drinking-code drinking-code commented Feb 4, 2020

add flat hand icon #831
use case: can be combined with other icons to create a hand that "gives" or as a standalone "asking for help"

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #836   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91118a6...a874af5. Read the comment docs.

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you used the commands in #171 to format your SVG ?

@drinking-code
Copy link
Contributor Author

@locness3 Oops, nope. Forgot that

@moeenio
Copy link

moeenio commented Feb 8, 2020

Can you please do it? Just npm run build if I'm not wrong

@drinking-code
Copy link
Contributor Author

drinking-code commented Feb 8, 2020

Sorry, I am new to git and GitHub.
I ran npm run build and when I try to commit now I get:

husky > npm run -s precommit (node v12.13.1)

 ↓ Running tasks for *.js [skipped]
   → No staged files match *.js
husky > npm run -s commitmsg (node v12.13.1)

[...]/feather/node_modules/@commitlint/cli/lib/help.js:34
		return `${fs.join(',')}${' '.repeat(4 + longest - length)}${desc}${ds}`;
		                             ^

RangeError: Invalid count value
    at String.repeat (<anonymous>)
    at [...]/feather/node_modules/@commitlint/cli/lib/help.js:34:32
    at Array.map (<anonymous>)
    at module.exports ([...]/feather/node_modules/@commitlint/cli/lib/help.js:23:15)
    at Object.<anonymous> ([...]/feather/node_modules/@commitlint/cli/lib/cli.js:58:76)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1047:10)

husky > commit-msg hook failed (add --no-verify to bypass)

how can I fix / evade this?

@moeenio
Copy link

moeenio commented Feb 9, 2020

What do you do to commit? git commit -m "commit message" ?

@drinking-code
Copy link
Contributor Author

yeah. I tried both git commit -m "commit message" and git commit -message="commit message". Also tried committing via GitHub Desktop

@moeenio
Copy link

moeenio commented Feb 12, 2020

Did you run npm install before ?

@moeenio
Copy link

moeenio commented Feb 12, 2020

I get that same error too, even with npm install (though I skipped the npm run build parts requiring me to install xcode, so that may just be this)

@drinking-code
Copy link
Contributor Author

drinking-code commented Feb 13, 2020

Perhaps it is this issue. This was fixed in commitlint v7.3.0. Can we try and update the module?

@moeenio
Copy link

moeenio commented Feb 13, 2020

Well, I guess you should edit these lines in packgae.json
https://github.com/drinking-code/feather/blob/icon-hand-flat/package.json#L35..L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants