Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add save-as icon #700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarcelloTheArcane
Copy link
Contributor

@MarcelloTheArcane MarcelloTheArcane commented Jul 24, 2019

Closes #609

Having problems with installing, so I haven't run any tests on this. @johnletey kindly formatted, so hopefully all good to go!

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3c64e93) to head (39bdd50).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #700   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moeenio
Copy link

moeenio commented Jul 24, 2019

You should rename to "feat: Add `save-as` icon"

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinging @colebemis

@MarcelloTheArcane MarcelloTheArcane changed the title Create save-as.svg feat: Add save-as icon Jul 24, 2019
@MarcelloTheArcane
Copy link
Contributor Author

@locness3 Done, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Save As
2 participants