Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add bed & building icons #662

Closed
wants to merge 5 commits into from
Closed

Feature: add bed & building icons #662

wants to merge 5 commits into from

Conversation

pkrawc
Copy link

@pkrawc pkrawc commented Jul 3, 2019 •
edited
Loading

Closes #68 & closes #391

@codecov
Copy link

codecov bot commented Jul 3, 2019 •
edited
Loading

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #662   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...766abc3. Read the comment docs.

@pkrawc pkrawc changed the title Add bed icon Add bed & building icons Jul 3, 2019
@pkrawc pkrawc changed the title Add bed & building icons Feature: add bed & building icons Jul 3, 2019
@moeenio
Copy link

moeenio commented Jul 3, 2019

You should say "Closes #68 and closes #391", because GitHub takes only into account the first one after "closes"

moeenio
moeenio reviewed Jul 3, 2019
View reviewed changes
Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building looks weird on GitHub rich diff
Screenshot_2019-07-03 Feature add bed building icons by pkrawc · Pull Request #662 · feathericons feather

@pkrawc
Copy link
Author

pkrawc commented Jul 3, 2019

Strange. I've updated the icon. I'm unsure why it was so convoluted before.

Good catch @locness3 .

@moeenio
Copy link

moeenio commented Jul 4, 2019

You should say "Closes #68 and closes #391", because GitHub takes only into account the first one after "closes"

Please do that as I already said.

@mittalyashu
Copy link
Contributor

Should the PR include a package-lock.json file?

The bed doesn't look like bed

Icon Suggestion
Figma_avnpvQYUAL Figma_ZfxKW6VAnp

@moeenio
Copy link

moeenio commented Jul 21, 2019

idk tbh

@pkrawc
Copy link
Author

pkrawc commented Jul 21, 2019

bed

Split the difference?

@Andreto Andreto mentioned this pull request Oct 31, 2020
Open
9 tasks
@pkrawc pkrawc closed this Jan 4, 2023
@moeenio
Copy link

moeenio commented Jan 5, 2023

Note that these icons have been added to @lucide-icons, a community fork :

https://lucide.dev/icon/building?search=building
https://lucide.dev/icon/bed?search=bed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moeenio moeenio moeenio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Request: Bed Icon request: bed
3 participants
@pkrawc @moeenio @mittalyashu