-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add pin and pin-vertical #626
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34 Continue to review full report at Codecov.
|
Could you try it with the tops slightly narrower? Just an idea 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe renaming to pin-2 ?
@junipf Keep the vertical pin name as The size of this titled pin is bigger as compared to the vertical pin. |
pin-titled ? |
Sorry, I mean |
Oh ok. |
They're sized to have at least 1px between the icon and the edge of the canvas per the guidelines. So long as they aren't used together (which they reasonably shouldn't be), I think this is preferable. I'm fine with any renaming |
They look a lot detailed |
Let's add all of them. Just to keep the shape of the pin consistent, can some copy the pinhead from an icon to another. |
@ahtohbi4 Could you increase the gap of the top ridge? |
@mittalyashu I don't think that it is a good idea to store a million kind of the same icons. It will turn a collection of good icons into a dump. 😌
@MarcelloTheArcane I can give you SVG-code of my variants if you'd like. |
But I love both icons 😭. |
Those are really great @ahtobi4! I think the head shape on yours are a lot more readable than mine, but they might be a bit noisey, so I'd love to play around with them and hopefully sort of merge our designs if you wouldn't mind. |
@junipf sure 🙂 Here is the code: <svg
xmlns="http://www.w3.org/2000/svg"
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M15 5a2 2 0 0 0 2-2V2H7v1c0 1.1.9 2 2 2m6 0l1 7m-1-7H9m7 7H8m8 0s3 .5 3 4H5c0-3.5 3-4 3-4m0 0l1-7M12 16v6" />
</svg> <svg
xmlns="http://www.w3.org/2000/svg"
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M17.85 10.2l-4.24 5.65m4.24-5.66L13.6 5.95m4.24 4.24a2 2 0 0 0 2.83 0l.7-.7-7.07-7.08-.7.71a2 2 0 0 0 0 2.83m0 9.9l-5.66-5.66m5.66 5.66s1.76 2.47-.71 4.95L3 10.9c2.47-2.48 4.95-.7 4.95-.7m0 0l5.66-4.25M7.95 15.85l-4.24 4.24" />
</svg> |
Used guidelines in #171
Fixes #407