-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon request: Digits #594
Comments
@locness3 @colebemis @curliq How does this look? I made the zero icon have a round zero, but I can change that to a square zero ... depending on what you guys think! |
Great! Although I think they are quite "squared", but I think we can't do much about this. |
@locness3 That was on purpose ... but yes, I don't think we can do much to change it! |
Was also thinking to have it either with no background so people could decide how to present them, or, to have a square background version and a circle background version. |
@curliq So are you saying get rid of the square surrounding the numbers? I say personally that the icons look to plain without the square! |
Or to add another variation with a circle around them, so people can choose between those two options. |
@locness3 What do you think? |
I think that would be great, since we already have circle/rectangle choices for other icons. |
Sounds good @locness3 ... will add digit icons with a circle border! |
Done @locness3 @curliq! |
That's great, although maybe you should turn the zero into a more "square" shape, to comply with other digits. |
@locness3 Same for the zero in the square icons? |
yes |
@locness3 Is it okay to submit a PR? |
idk really |
why not @locness3? |
If you want |
Why not @locness3! Opening a PR now! |
Icon Request
The text was updated successfully, but these errors were encountered: