-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon Request: HD icon #557
Comments
I'm not a designer, I barely know how to move things on illustrator. I attached everything so someone with more knowledge can make it aligned to the guidelines. |
That's a good suggestion for a font icon. |
Pixel perfect: Do this pass the 'no fill' rule? There is no (decent) way of making the HD with strokes. I got the HD from Material Design icons and modified the D with an outside 2px corner to match the specs. If you are satisfied, I can submit it as PR. @colebemis |
@locness3 @colebemis @bernaferrari How does this look? I followed #171 |
It looks great, although idk if using corner radius is allowed. What do you think @colebemis ? |
@locness3 I personally think without the corner radius it looks like H0 and not HD ... but what is your opinion @colebemis? |
I'm not sure what's wrong with the one I sent a few months ago. |
@bernaferrari It didn't follow #171 ... the team is really strict about new icons following these rules! Although when you do follow them ... your icon looks really nice 😍! That is why they are there! |
You could have mentioned this a few months ago.. I tried to follow everything, it is 2px everywhere. |
@bernaferrari Yes ... it appears you did follow the 2px rule ... but there is also the rule of rounded edges (among others) ... do go and read #171 ... and ask me any questions if anything doesn't make sense ... it personally took me a while to understand what they meant! |
I suppose you try to get something like that: <svg
xmlns="http://www.w3.org/2000/svg"
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M14 9H16C17.1046 9 18 9.89543 18 11V13C18 14.1046 17.1046 15 16 15H14V9Z" />
<path d="M6 9L6 15" />
<path d="M10 12H6" />
<path d="M10 9L10 15" />
<rect x="2" y="2" width="20" height="20" rx="2" />
</svg> |
@ahtohbi4 How is this different from the one that I made? |
@johnletey from this one? |
Thanks @locness3! |
I really liked that @ahtohbi4. Your H is less spaced. |
Got it @bernaferrari! |
|
@bernaferrari @johnletey if you wish, I could create a PR with this version? |
@ahtohbi4 Go for it! You guys didn't like my version (and I personally like yours better 😄)! |
I thought it would be nice to have a HD icon, like x-square and many others.
I did really on Illustrator something like this:
(ignore the black
D
, I don't know how to make it intersect)Inspired by this:
https://material.io/tools/icons/?search=hd&icon=hd&style=outline
I think if you can get the margins correctly, it can become a really nice icon and not hard to make.
This is the project, in case anyone wants to play with it:
x-square-hd.ai.zip
The text was updated successfully, but these errors were encountered: