Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: specify event uri and streaming uri #9

Merged
merged 2 commits into from
Oct 17, 2023
Merged

doc: specify event uri and streaming uri #9

merged 2 commits into from
Oct 17, 2023

Conversation

cosmic-flood
Copy link
Contributor

The first time I tried dependency injection without these two configurations, it gave me no warning, it just did not work.

I only found the error by examining the log.

So I think it's much better to add these two variables to the sample code.

…xample

The first time I tried dependency injection without these two configurations, it gave me no warning, it just did not work.

I only found the error by examining the log.

So I think it's much better to add these two variables to the sample code. For better UX
@deleteLater deleteLater changed the title Added EventUri and StreamingUri params in Dependency Injection Code Sample doc: specify event uri and streaming uri Oct 17, 2023
Copy link
Contributor

@deleteLater deleteLater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deleteLater deleteLater merged commit f038bb6 into main Oct 17, 2023
@deleteLater deleteLater deleted the doc/readme branch October 17, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants