Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community SDK section to API docs #992

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

MichaelHirn
Copy link
Contributor

@MichaelHirn MichaelHirn commented Sep 9, 2020

including reference to community-provided Node.js SDK

What this PR does / why we need it:

  1. Adds a Community Contributions section in the reference > api docs
  2. Adds a link to the community provided Node.js SDK

cc @woop

Which issue(s) this PR fixes:

Does not fix an issue

Does this PR introduce a user-facing change?:

NONE

Notes

  • CLA signed
  • ❓I'm not sure if only (docs/reference/api/README.md) or also (docs/reference/api.md) need to be edited. I got the feeling that docs/reference/api.md might be stale, but edited it anyway

including reference to community-provided Node.js SDK
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MichaelHirn
To complete the pull request process, please assign pyalex
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @MichaelHirn. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MichaelHirn
Copy link
Contributor Author

/assign @pyalex

@woop
Copy link
Member

woop commented Sep 10, 2020

/lgtm

@woop woop merged commit e0dfb67 into feast-dev:master Sep 10, 2020
@woop
Copy link
Member

woop commented Sep 10, 2020

@MichaelHirn you should probably backport this to the 0.7 branch as well, because that is what is going to be live on docs.feast.dev

@feast-ci-bot
Copy link
Collaborator

@MichaelHirn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end e2a6689 link /test test-end-to-end

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants