Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go test #97

Merged
merged 2 commits into from
Jan 21, 2019
+20 −11
Merged

Fix go test #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c008553
Fix timezone printing to be UTC
Jan 21, 2019
40af0f3
Revert timestamp printing to be timezone sensitive
Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions cli/feast/pkg/printer/printer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package printer

import (
"fmt"
"testing"

"github.com/gojek/feast/cli/feast/pkg/util"

"github.com/golang/protobuf/ptypes/timestamp"

"github.com/gojek/feast/protos/generated/go/feast/core"
Expand Down Expand Up @@ -42,7 +45,7 @@ func TestPrintFeature(t *testing.T) {
LastUpdated: &timestamp.Timestamp{Seconds: 1},
Created: &timestamp.Timestamp{Seconds: 1},
},
expected: `Id: test.none.test_feature_two
expected: fmt.Sprintf(`Id: test.none.test_feature_two
Entity: test
Owner: [email protected]
Description: testing feature
Expand All @@ -51,11 +54,13 @@ Uri: https://github.com/bob/example
DataStores:
Serving: REDIS
Warehouse: BIGQUERY
Created: 1970-01-01T07:30:01+07:30
LastUpdated: 1970-01-01T07:30:01+07:30
Created: %s
LastUpdated: %s
Related Jobs:
- job1
- job2`,
util.ParseTimestamp(timestamp.Timestamp{Seconds: 1}),
util.ParseTimestamp(timestamp.Timestamp{Seconds: 1})),
}, {
name: "no storage",
input: &core.UIServiceTypes_FeatureDetail{
Expand All @@ -74,17 +79,19 @@ Related Jobs:
LastUpdated: &timestamp.Timestamp{Seconds: 1},
Created: &timestamp.Timestamp{Seconds: 1},
},
expected: `Id: test.none.test_feature_two
expected: fmt.Sprintf(`Id: test.none.test_feature_two
Entity: test
Owner: [email protected]
Description: testing feature
ValueType: INT64
Uri: https://github.com/bob/example
Created: 1970-01-01T07:30:01+07:30
LastUpdated: 1970-01-01T07:30:01+07:30
Created: %s
LastUpdated: %s
Related Jobs:
- job1
- job2`,
util.ParseTimestamp(timestamp.Timestamp{Seconds: 1}),
util.ParseTimestamp(timestamp.Timestamp{Seconds: 1})),
},
}

Expand All @@ -109,13 +116,14 @@ func TestPrintEntity(t *testing.T) {
LastUpdated: &timestamp.Timestamp{Seconds: 1},
}
out := PrintEntityDetail(entityDetail)
expected := `Name: test
expected := fmt.Sprintf(`Name: test
Description: my test entity
Tags: tag1,tag2
LastUpdated: 1970-01-01T07:30:01+07:30
LastUpdated: %s
Related Jobs:
- job1
- job2`
- job2`,
util.ParseTimestamp(timestamp.Timestamp{Seconds: 1}))
if out != expected {
t.Errorf("Expected output:\n%s \nActual:\n%s \n", expected, out)
}
Expand All @@ -134,12 +142,13 @@ func TestPrintStorage(t *testing.T) {
LastUpdated: &timestamp.Timestamp{Seconds: 1},
}
out := PrintStorageDetail(storageDetail)
expected := `Id: REDIS1
expected := fmt.Sprintf(`Id: REDIS1
Type: redis
Options:
option1: value1
option2: value2
LastUpdated: 1970-01-01T07:30:01+07:30`
LastUpdated: %s`,
util.ParseTimestamp(timestamp.Timestamp{Seconds: 1}))
if out != expected {
t.Errorf("Expected output:\n%s \nActual:\n%s \n", expected, out)
}
Expand Down