Keep StoreProto inside JobStore to decouple JobCoordination from SpecService internals #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
changed the title
|
/test test-end-to-end-auth |
|
/test test-end-to-end-redis-cluster |
woop
reviewed
Jul 1, 2020
woop
reviewed
Jul 1, 2020
woop
reviewed
Jul 1, 2020
|
/retest |
|
/lgtm |
woop
approved these changes
Jul 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test test-end-to-end-batch |
|
/test test-end-to-end-auth |
1 similar comment
|
/test test-end-to-end-auth |
|
/test test-end-to-end-auth |
1 similar comment
|
/test test-end-to-end-auth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR reverts #846 to keep Job and Store more decoupled (and not use StoreRepository from JobCoordinator).
Now Job keeps full copy of related Stores (in proto) in
jobs_storestable. It allows us to compare deployed stores with new one coming fromSpecServiceand upgrade IngestionJob if needed.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: