-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move read transforms into "source" package as FeatureSources #74
Conversation
/hold |
/assign pradithya |
/hold cancel I think this is ready to merge now. This introduces breaking changes, for the import spec for file based imports, the "type" changes like so:
|
@zhilingc @pradithya can you please review this? |
I think core will also need to change since it check for the import spec before submitting it, correct @zhilingc ? |
updated core import spec validator class |
/lgtm |
Seems good. You're missing the license in some of the files though. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removed with_subclasses option (it's the default and unique behavior)
First attempt #61
/donotmerge
/assign zhilingc