Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3 backport: Add Java coverage reporting #734

Merged

Conversation

ches
Copy link
Member

@ches ches commented May 23, 2020

What this PR does / why we need it:

Backports #686 to v0.3-branch. Also backports #410, which was a final missing piece for v0.3 after #407—this fixes the Prow job for publish-docker-images on the branch.

I have possibly a few of these housekeeping-ish things that I want to bring in internally, and as much as possible / whenever valuable for mainline Feast I'm trying to do things as upstream master => upstream backport => bring backport in-house. If PR reviews and so forth become a burden though, if you aren't supporting any v0.3 deployments yourselves anymore, I'm happy for us to "formally" take ownership of the maintenance branch in whatever ways make sense.

Does this PR introduce a user-facing change?:

NONE

@ches
Copy link
Member Author

ches commented May 23, 2020

/assign @woop

@ches
Copy link
Member Author

ches commented May 23, 2020

/hold

I think some of the work for setting Feast version consistently needs to be backported also to fix the publish-docker-images Prow step, I'll look at this.

@ches ches changed the title v0.3 backport: Java coverage reporting v0.3 backport: Add Java coverage reporting May 23, 2020
@woop
Copy link
Member

woop commented May 23, 2020

Thanks @ches

I'm happy for us to "formally" take ownership of the maintenance branch in whatever ways make sense.

Given the maturity of the project and intention of most "regulars" of the project, I think we will have less problems with people cleaning things up than they introduce. Happy to reduce red tape. Also happy for you to formally take ownership of 0.3 that makes things easier.

Please let me know if there are any technical challenges (access?) that stand in your way. I have made you an admin on the repo if that helps with anything.

@ches
Copy link
Member Author

ches commented May 23, 2020

Please let me know if there are any technical challenges (access?) that stand in your way. I have made you an admin on the repo if that helps with anything.

None that I'm currently aware of, I'll try the next release process after we get a few things in and see if anything comes up.

We're probably the only ones opening PRs against v0.3-branch, I can ask another Agodan to be a reviewer for these. I guess at least one of us would need to be an approver for Prow to do the merges without asking one of you.

@woop
Copy link
Member

woop commented May 23, 2020

Please let me know if there are any technical challenges (access?) that stand in your way. I have made you an admin on the repo if that helps with anything.

None that I'm currently aware of, I'll try the next release process after we get a few things in and see if anything comes up.

We're probably the only ones opening PRs against v0.3-branch, I can ask another Agodan to be a reviewer for these. I guess at least one of us would need to be an approver for Prow to do the merges without asking one of you.

Feel free to add more contributors/reviewers/approvers as needed.

@ches
Copy link
Member Author

ches commented May 23, 2020

/hold cancel

@woop
Copy link
Member

woop commented May 23, 2020

/lgtm

@woop
Copy link
Member

woop commented May 23, 2020

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ches, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 0eb9c56 into feast-dev:v0.3-branch May 23, 2020
@ches ches deleted the v0.3-backport-686-java-coverage branch May 23, 2020 11:07
@ches
Copy link
Member Author

ches commented May 23, 2020

Thanks for the quick reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants