Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract fs update tests so ci doesn't run it #709

Merged
merged 2 commits into from
May 15, 2020

Conversation

zhilingc
Copy link
Collaborator

What this PR does / why we need it:
The tests take too long, and timeout frequently because the bq streaming cache refresh doesn't happen within a deterministic amount of time.

The tests can still be run locally if the functionality needs to be tested.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@khorshuheng
Copy link
Collaborator

khorshuheng commented May 15, 2020

tests/e2e/bq-batch-fs-updates.py can be included in prow, but with auto run set as false. That way, we can trigger the test from prow manually if needed. Though, i am open to do this in a separate PR rather than the current one.

@zhilingc zhilingc force-pushed the extract-version-batch-tests branch from c6afb1f to dc09f53 Compare May 15, 2020 04:51
@zhilingc
Copy link
Collaborator Author

/test test-end-to-end

@khorshuheng
Copy link
Collaborator

/lgtm

@khorshuheng
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [khorshuheng,zhilingc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 727ec0a into feast-dev:master May 15, 2020
@feast-ci-bot
Copy link
Collaborator

@zhilingc: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

What this PR does / why we need it:
The tests take too long, and timeout frequently because the bq streaming cache refresh doesn't happen within a deterministic amount of time.

The tests can still be run locally if the functionality needs to be tested.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants