-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique ingestion id for all batch ingestions #656
Conversation
/test test-end-to-end |
/test test-end-to-end-batch |
I am personally happy to merge this at any time. I'll leave it open for a little bit. |
Fine from me functionally. I have the exact same reaction as @woop on #612 (comment) – the name "dataset" feels off to me for this, and my first inclination was also |
@ches I just felt it was more intuitive to provide a dataset id over an ingestion id, and in the old PR I originally offered the functionality for the user to be able to set it, but it was punted to when we integrate these ids into batch retrieval. But i can't say i'm too opinionated about this. if you guys think it should be |
I think your previous concern was around the retrieval of statistics based on an We are starting to overload this So anyway, my preference is |
Renamed to |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is a split-off off #612 that introduces the model changes made in that PR in a more digestible chunk.
Adds a unique identifier for all discrete batch loads of data into feast for re-referencing the set of data later on.
Does this PR introduce a user-facing change?: