-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make error on retrieval of nonexistent feature humanly readable #625
Conversation
…c retrieval error.
…errors from feast serving.
Max age isn't a part of the feature reference, so I think that should be removed. |
serving/src/main/java/feast/serving/specs/CachedSpecService.java
Outdated
Show resolved
Hide resolved
/ok-to-test |
/test test-serving |
/test test-end-to-end |
/test test-end-to-end-batch |
@woop I have removed the max age from the error message. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Notifies the user with a human readable error when the user attempts to retrieve
(both online/batch) feature data from feast serving with an feature reference does not match any feature stored in feast.
Which issue(s) this PR fixes:
Fixes #454
Does this PR introduce a user-facing change?: