Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clear all the futures when sync is called. #501

Merged
merged 12 commits into from
Feb 27, 2020
Merged

[Bug] Clear all the futures when sync is called. #501

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
96aebde
Replacing Jedis With Lettuce in ingestion and serving
Feb 22, 2020
244fa85
Merge branch 'feastmaster'
Feb 25, 2020
ccecd61
Removing extra lines
Feb 25, 2020
6a7fb0c
Abstacting redis connection based on store
Feb 25, 2020
8953a7a
Check the connection before connecting as lettuce does the retry auto…
Feb 26, 2020
37d7198
Running spotless
Feb 26, 2020
0feb768
Merge branch 'master' into master
lavkesh Feb 26, 2020
63f0681
Throw Exception if the job store config is null
Feb 27, 2020
4fa2c9b
Merge branch 'master' of github.com:lavkesh/feast
Feb 27, 2020
c977b79
Handle No enum constant RuntimeException
Feb 27, 2020
1894b20
Merge branch 'feastmaster'
Feb 27, 2020
e2349ca
Future should be cleared everytime sync is called
Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ingestion/src/main/java/feast/store/serving/redis/RedisStandaloneIngestionClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ public boolean isConnected() {
public void sync() {
// Wait for some time for futures to complete
// TODO: should this be configurable?
LettuceFutures.awaitAll(60, TimeUnit.SECONDS, futures.toArray(new RedisFuture[0]));
futures.clear();
try {
LettuceFutures.awaitAll(60, TimeUnit.SECONDS, futures.toArray(new RedisFuture[0]));
woop marked this conversation as resolved.
Show resolved Hide resolved
} finally {
futures.clear();
woop marked this conversation as resolved.
Show resolved Hide resolved
}
}

@Override
Expand Down