Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail Spotless formatting check before tests execute #487

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Fail Spotless formatting check before tests execute #487

merged 2 commits into from
Feb 24, 2020

Commits on Feb 23, 2020

  1. Fail formatting check before tests execute 

    By default, the spotless Maven plugin binds its check goal to the verify
phase (late in the lifecycle, after integration tests). Because we
currently only run `mvn test` for CI, it doesn't proceed as far as
verify so missed formatting is not caught by CI.

This binds the check to an earlier phase, in between test-compile and
test, so that it will fail before `mvn test` but not disrupt your dev
workflow of compiling main and test sources as you work. This strikes a
good compromise on failing fast for code standards without being _too_
nagging.

For the complete lifecycle reference, see:
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
    @ches
    ches committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    cf29060 View commit details
    Browse the repository at this point in the history

  2. Apply spotless formatting

    @ches
    ches committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    ec0a6da View commit details
    Browse the repository at this point in the history