Extend WriteMetricsTransform in Ingestion to write feature value stats to StatsD #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
davidheryanto
force-pushed
the
feast-ingestion-feature-value-metric
branch
from
08606ed to
7603aa8
Compare
davidheryanto
force-pushed
the
feast-ingestion-feature-value-metric
branch
from
7603aa8 to
a87eee2
Compare
woop
reviewed
Feb 23, 2020
ingestion/src/main/java/feast/ingestion/options/ImportOptions.java
Outdated
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/transform/metrics/WriteFeatureValueMetricsDoFn.java
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/transform/metrics/WriteFeatureValueMetricsDoFn.java
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/transform/metrics/WriteFeatureValueMetricsDoFn.java
Show resolved
Hide resolved
Since there are other exception like UnknownHostException that can be thrown and we want to know such error. Also change the log level to error because so it's not normal for client to fail to be created"
davidheryanto
force-pushed
the
feast-ingestion-feature-value-metric
branch
from
686f0f8 to
ed268eb
Compare
…warn) On 2nd thought, this should constitute an error not a warning
|
/retest |
|
/lgtm |
davidheryanto
added a commit
to davidheryanto/feast
that referenced
this pull request
Feb 26, 2020
…s to StatsD (feast-dev#486) * Extend WriteMetricsTransform to write feature value stats to StatsD * Apply mvn spotless * Catch all exception not just StatsDClientException during init Since there are other exception like UnknownHostException that can be thrown and we want to know such error. Also change the log level to error because so it's not normal for client to fail to be created" * Change log level due to invalid feature set ref to error (previously warn) On 2nd thought, this should constitute an error not a warning * Apply maven spotless to metric transform codes (cherry picked from commit 5508c92)
zhilingc
pushed a commit
that referenced
this pull request
Feb 26, 2020
…s to StatsD (#486) * Extend WriteMetricsTransform to write feature value stats to StatsD * Apply mvn spotless * Catch all exception not just StatsDClientException during init Since there are other exception like UnknownHostException that can be thrown and we want to know such error. Also change the log level to error because so it's not normal for client to fail to be created" * Change log level due to invalid feature set ref to error (previously warn) On 2nd thought, this should constitute an error not a warning * Apply maven spotless to metric transform codes (cherry picked from commit 5508c92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a step (blue coloured box) to write stats for numerical value of every feature to StatsD.
A fixed window (default to 30s) will first be applied, before the stats calculation of each feature. This is to ensure the metrics collector is not overwhelmed with metrics data (and drop the metrics as a result). For validation of features by value, an aggregated windowed view of the values is also usually adequate.
The following
gaugemetrics will be sent to StatsD for every feature at the end of the window:Which issue(s) this PR fixes:
Related to #172
Does this PR introduce a user-facing change?: