Remove transaction from Ingestion

[imjuanleonard]

QA this change first

[feast-ci-bot]

Hi @imjuanleonard. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[imjuanleonard]

/test all

[feast-ci-bot]

@imjuanleonard: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[woop]

/ok-to-test

[davidheryanto]

/lgtm

[davidheryanto]

This is to ensure that Redis write in ingestion code does not unnecessarily block all other clients during writing. Since currently in Feast v0.4, this Redis is also shared by Feast Serving, if Feast Ingestion somehow attempts too much write (due to retry maybe or connection error maybe), excessive Redis locks may be used. Redis clients in Feast serving will be blocked and this leads to increased latency in Feast serving (which is usually latency sensitive).

Locks/transaction is not really necessary in this case (it is good to have). Atomic writes of a batch of feature values are not really needed because these it's ok it these writes command in a batch are interleaved with other commands, without resulting in corrupted feature values

[davidheryanto]

/approve

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto, imjuanleonard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidheryanto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[imjuanleonard]

some panda library TypeError because of time
pandas/_libs/tslibs/timestamps.pyx:413: TypeError
TypeError: Timestamp subtraction must have the same timezones or no timezones

I guess this is similar to another pipeline

[imjuanleonard]

/assign @davidheryanto

[davidheryanto]

/retest
Previous test failure due to new version of fastavro. Master branch currenly set a fixed version for fastavro.

[imjuanleonard]

/lgtm

[feast-ci-bot]

@imjuanleonard: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[woop]

/lgtm