chore: Updating latest requirements to fix broken CI #4683
Merged
+420
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Arceo <[email protected]>
|
@tokoko can you reproduce this issue locally? I'm not able to reproduce this linter error. |
|
no, I'm usually running lowest python version locally though (3.9), maybe it is 3.11-specific. |
|
I tried it with 3.11 and wasn't able to reproduce... @dmartinol any chance you can check this out? |
dmartinol
reviewed
Oct 24, 2024
| @@ -458,7 +460,7 @@ multidict==6.1.0 | |||
| # via | |||
| # aiohttp | |||
| # yarl | |||
| mypy==1.11.2 | |||
| mypy==1.13.0 | |||
There was a problem hiding this comment.
revert this one.
I think the issue is due to this change in 1.11.2
There was a problem hiding this comment.
Oh nice, thank you!
There was a problem hiding this comment.
Actually I'll just patch the issue
There was a problem hiding this comment.
Going to patch it in a separate PR actually. Let's merge this and fix master.
@dmartinol can you review?
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
emgeee
approved these changes
Oct 24, 2024
lokeshrangineni
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updating latest requirements to fix broken CI
Which issue(s) this PR fixes:
Master CI is broken
Misc