-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RedisBackedJobService to use a connection pool #439
Conversation
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
not sure if this is bc of this change, but to get minikube working w basic.ipynb, I had to do:
o/w ingest() would fail w/ cannot conn to redis |
@b133t Which image version are you using? |
0.4.3 |
* Change job service connection to use a connection pool * Close connection * Remove isConnected condition * Add simple test to test that pool recovers broken connections * Catch JedisExceptions separately * Catch only JedisConnectionException
What this PR does / why we need it:
Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch retrieval is unusable until the instance is restarted to manually establish a new connection with redis.
This PR changes RedisBackedJobService to use a connection pool instead.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: