Remove "resource" concept and the need to specify a kind in feature sets #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
requested review from
davidheryanto,
khorshuheng,
pradithya and
zhilingc
as code owners
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Feb 13, 2020
davidheryanto
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Update Changelog (#423) * Initial commit of changelog up to 0.4.3 * Remove unreleased changes on master * Add missing changelog manually Co-authored-by: Khor Shu Heng <[email protected]> * Introduce datatypes/java module for proto generation (#391) Rather than the Maven protobuf plugin running on the same symlinked definitions in several Java modules, localize this process into one module that the others depend on. This provides a single module that can be depended on by third-party extensions with the bare minimum of dependencies. Also removes proto files that are no longer used. * Update basic Feast example to Feast 0.4 (#424) * Add documentation for bigquery batch retrieval (#428) * Add documentation for bigquery batch retrieval * Fix formatting for multiline comments * Bump hibernate-validator from 6.0.13.Final to 6.1.0.Final in /ingestion (#421) Bumps [hibernate-validator](https://github.com/hibernate/hibernate-validator) from 6.0.13.Final to 6.1.0.Final. - [Release notes](https://github.com/hibernate/hibernate-validator/releases) - [Changelog](https://github.com/hibernate/hibernate-validator/blob/master/changelog.txt) - [Commits](hibernate/hibernate-validator@6.0.13.Final...6.1.0.Final) Signed-off-by: dependabot[bot] <[email protected]> * Publish datatypes/java along with sdk/java (#426) This forward-ports a straggling commit from #407: it was missed when initially creating the datatypes module because Sonatype publishing setup was added concurrently. * Remove "resource" concept and the need to specify a kind in feature sets (#432) * Update GKE installation and chart values to work with 0.4.3 (#434) * Fix logging (#430) Allow log level to be set via environmental variable. Add ability to set appender type in serving. Remove logback-classic from ingestion as it is a library so should not bring its own impl. Upgrade log4j to 2.12.1 to support objectMessageAsJsonObject. Fix logger config targeting feast package in serving an add same concept for core. * Bump chart version * Update Changelog (#447) * Update Changelog * Remove closed issues Co-authored-by: Willem Pienaar <[email protected]> Co-authored-by: Ches Martin <[email protected]> Co-authored-by: Chen Zhiling <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lionel Vital <[email protected]> Co-authored-by: Iain Rauch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feature-setWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: