Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature/adding remote online store #4226

Merged
merged 3 commits into from
Jun 14, 2024
Merged

feat: Feature/adding remote online store #4226

merged 3 commits into from
Jun 14, 2024

Conversation

lokeshrangineni
Copy link
Contributor

@lokeshrangineni lokeshrangineni commented May 24, 2024 •
edited
Loading

What this PR does / why we need it:

Adds the new online store of type "remote" which will interact with remote feature server. Able to read and write the features only at the moment.

Which issue(s) this PR fixes:

#4121

@lokeshrangineni lokeshrangineni mentioned this pull request May 24, 2024
Closed
@lokeshrangineni
Copy link
Contributor Author

cc: @tokoko @dmartinol

@lokeshrangineni lokeshrangineni changed the title Feature/adding remote onlinestore rebase [WIP] -[DRAFT] Feature/adding remote onlinestore rebase May 24, 2024
@lokeshrangineni lokeshrangineni changed the title [WIP] -[DRAFT] Feature/adding remote onlinestore rebase [WIP] -[DRAFT] Feature/adding remote online store May 24, 2024
@lokeshrangineni lokeshrangineni changed the title [WIP] -[DRAFT] Feature/adding remote online store feat: Feature/adding remote online store Jun 3, 2024
@lokeshrangineni lokeshrangineni marked this pull request as ready for review June 3, 2024 16:07
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-remote-onlinestore-rebase branch 5 times, most recently from 5508d31 to d5b27c6 Compare June 3, 2024 18:37
@lokeshrangineni lokeshrangineni changed the base branch from master to v0.21-branch June 6, 2024 16:37
@lokeshrangineni lokeshrangineni changed the base branch from v0.21-branch to master June 6, 2024 16:37
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-remote-onlinestore-rebase branch from 78a9020 to 720b6e0 Compare June 6, 2024 16:43
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-remote-onlinestore-rebase branch from 7e324ae to d895fdc Compare June 12, 2024 15:43
@lokeshrangineni lokeshrangineni changed the base branch from master to woop-patch-2 June 12, 2024 15:46
@lokeshrangineni lokeshrangineni changed the base branch from woop-patch-2 to master June 12, 2024 15:46
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-remote-onlinestore-rebase branch from 1a7e4db to 5231bac Compare June 12, 2024 19:47
@lokeshrangineni lokeshrangineni changed the base branch from master to woop-patch-2 June 13, 2024 14:16
@lokeshrangineni lokeshrangineni changed the base branch from woop-patch-2 to master June 13, 2024 14:17
@lokeshrangineni lokeshrangineni changed the base branch from master to fv-type June 13, 2024 14:19
@lokeshrangineni lokeshrangineni changed the base branch from fv-type to master June 13, 2024 14:19
redhatHameed
redhatHameed reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@redhatHameed redhatHameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minor comments

Makefile Outdated Show resolved Hide resolved
tokoko
tokoko approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@tokoko tokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lokeshrangineni
Copy link
Contributor Author

After approved by @tokoko, just rebased the branch with feast-dev:master branch. No changes made to PR after the approval.

@lokeshrangineni lokeshrangineni changed the base branch from master to v0.20-branch June 13, 2024 23:19
@lokeshrangineni lokeshrangineni changed the base branch from v0.20-branch to master June 13, 2024 23:19
@lokeshrangineni
squashing last 61 commits.
f2079fb 
Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase

Signed-off-by: Lokesh Rangineni <[email protected]>
@lokeshrangineni lokeshrangineni force-pushed the feature/adding-remote-onlinestore-rebase branch from b1a1535 to f2079fb Compare June 13, 2024 23:36
@lokeshrangineni lokeshrangineni changed the base branch from master to v0.20-branch June 13, 2024 23:37
@lokeshrangineni lokeshrangineni changed the base branch from v0.20-branch to master June 13, 2024 23:39
@lokeshrangineni
squashing last 61 commits.
0aeb0a6 
Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase

Signed-off-by: Lokesh Rangineni <[email protected]>
@lokeshrangineni
Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-…
331e623 
…rebase' into feature/adding-remote-onlinestore-rebase
@franciscojavierarceo franciscojavierarceo merged commit 9454d7c into feast-dev:master Jun 14, 2024
16 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Jun 18, 2024
@feast-ci-bot
chore(release): release 0.39.0
df46cae 
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18)

### Bug Fixes

* Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8))
* Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce))
* Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76))
* Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57))
* Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1))
* Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66))
* Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438))

### Features

* Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384))
* Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da))
* Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9))
* Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831))
* Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662))
* Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c))
* List all feature views ([#4256](#4256)) ([36a574d](36a574d))
* Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143))
* Remote offline Store  ([#4262](#4262)) ([28a3d24](28a3d24))
* Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmartinol dmartinol dmartinol left review comments

@redhatHameed redhatHameed redhatHameed left review comments

@tokoko tokoko tokoko approved these changes

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

@whoahbot whoahbot Awaiting requested review from whoahbot

@sfc-gh-madkins sfc-gh-madkins Awaiting requested review from sfc-gh-madkins

@DvirDukhan DvirDukhan Awaiting requested review from DvirDukhan

@sudohainguyen sudohainguyen Awaiting requested review from sudohainguyen

@niklasvm niklasvm Awaiting requested review from niklasvm

@kevjumba kevjumba Awaiting requested review from kevjumba

@yelo-blood yelo-blood Awaiting requested review from yelo-blood

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lokeshrangineni @franciscojavierarceo @tokoko @redhatHameed @dmartinol