Unserializable FluentBackoff cause null pointer exception in Dataflow Runner #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ches
reviewed
Jan 8, 2020
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| public class BackOffExecutor implements Serializable { | |||
|
|
|||
| private static FluentBackoff backoff; | |||
| private FluentBackoff backoff; | |||
There was a problem hiding this comment.
Maybe it was meant to be final instead? Seems like it can be.
khorshuheng
force-pushed
the
bugfix-static-backoff
branch
2 times, most recently
from
c593859 to
48dd24d
Compare
khorshuheng
changed the title
zhilingc
reviewed
Jan 8, 2020
khorshuheng
force-pushed
the
bugfix-static-backoff
branch
from
48dd24d to
5778ad0
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
added a commit
to khorshuheng/feast
that referenced
this pull request
Jan 8, 2020
khorshuheng
added a commit
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backoff variable has been mistakenly assigned the static modifier. This doesn't affect DirectRunner, but on Dataflow Runner this seems to result in Nullpointer exception.
Edited: FluentBackoff shouldn't have been setup on the constructor, as it is unserializable. Passing the backoff as function argument fixed this. Thanks to @zhilingc for helping me to identify this.