Change register to apply #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradithya
approved these changes
Dec 12, 2018
woop
reviewed
Dec 12, 2018
| * @param otherFeatureGroup | ||
| * @return boolean | ||
| */ | ||
| public boolean eq(FeatureGroupInfo otherFeatureGroup) { |
There was a problem hiding this comment.
Isn't it possible (and perhaps cleaner) to use the built in .equals() method that all Java objects have?
https://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#equals(java.lang.Object)
| EntityInfo entity1 = new EntityInfo(entitySpec); | ||
| entity1.setCreated(Date.from(Instant.ofEpochSecond(1))); | ||
| EntityInfo entity2 = new EntityInfo(entitySpec); | ||
| entity1.setCreated(Date.from(Instant.ofEpochSecond(2))); |
There was a problem hiding this comment.
Is this line correct? Shouldn't it be entity2.setCreated(Date.from(Instant.ofEpochSecond(2)));?
woop
reviewed
Dec 12, 2018
| && oldStoreOpts.equals( | ||
| newStore == null | ||
| ? "" | ||
| : TypeConversion.convertMapToJsonString(newStore.getOptionsMap())); |
There was a problem hiding this comment.
Do we really need to have oldStoreOpts here? Can this also be a method on StorageInfo?
|
Cleaned it up a bit. |
woop
approved these changes
Dec 13, 2018
| return storageInfo; | ||
| } else { | ||
| storageInfo = new StorageInfo(spec); | ||
| StorageInfo out = storageInfoRepository.saveAndFlush(storageInfo); |
There was a problem hiding this comment.
Isn't there a more descriptive variable name that we can use instead of out?
Yanson
pushed a commit
to Yanson/feast
that referenced
this pull request
Jul 29, 2020
Builds, tests and runs Docker container for Feast core as well as needed services (Kafka, Redis and PostgreSQL). Uses a self-hosted agent VM (deployed on Azure) to speed up build thanks to Docker layer caching. The Docker Action automatically runs whenever a PR is made.
dmartinol
pushed a commit
to dmartinol/feast
that referenced
this pull request
May 15, 2024
Integrating comments
tsisodia10
pushed a commit
to tsisodia10/feast
that referenced
this pull request
Jul 23, 2024
# This is the 1st commit message: chore: Bump ws from 7.5.6 to 7.5.10 in /ui (feast-dev#4292) # This is the commit message feast-dev#2: Remove metric checks Signed-off-by: Twinkll Sisodia <[email protected]> # This is the commit message feast-dev#3: Draft different md file # This is the commit message feast-dev#4: Refine opentelemetry.md # This is the commit message feast-dev#5: Refine opentelemetry.md # This is the commit message feast-dev#6: Refine opentelemetry.md # This is the commit message feast-dev#7: Refine opentelemetry.md
tsisodia10
pushed a commit
to tsisodia10/feast
that referenced
this pull request
Jul 23, 2024
# This is the 1st commit message: chore: Bump ws from 7.5.6 to 7.5.10 in /ui (feast-dev#4292) # This is the commit message feast-dev#2: Remove metric checks Signed-off-by: Twinkll Sisodia <[email protected]> # This is the commit message feast-dev#3: Draft different md file # This is the commit message feast-dev#4: Refine opentelemetry.md # This is the commit message feast-dev#5: Refine opentelemetry.md # This is the commit message feast-dev#6: Refine opentelemetry.md # This is the commit message feast-dev#7: Refine opentelemetry.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change register API to apply.
If you apply a spec for a resource that doesn't already exist in the system, it will be created. If not, then the resource will be updated to match the new spec provided. Note that only fields without dependencies can be updated; i.e. changes to ids, storage sinks, or value types are not allowed. If you apply a spec that has no changes without throwing an error.
Updated the CLI to reflect these changes as well.