-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async job management #361
Async job management #361
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
This is still a [WIP]? |
Yeah. I haven't implemented safe ingestion yet (hence the e2e tests are failing) |
Pushed changes for safe ingestion: This mainly involves
Unfortunately this might introduce quite a bit of lag, particularly if a user submits their feature set directly after feast starts updating its jobs. Will need to think this through and fix in a further PR, but it works decently in the interim. The change to the protos is more or less consistent with what is described in the issue #363. |
/hold cancel |
core/src/main/java/feast/core/service/JobCoordinatorService.java
Outdated
Show resolved
Hide resolved
/retest |
/retry |
…to take full FeatureSet object
/lgtm |
Currently jobs are kicked off in a synchronous way when feature sets are applied. This is an issue because it is:
This PR moves all job management to a worker thread.
The goal is to: