Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure no duplicates in fv.schema #3460

Merged
merged 2 commits into from
Jan 20, 2023
Merged

fix: Ensure no duplicates in fv.schema #3460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
927f073
Ensure no duplicates in `fv.schema`
felixwang9817 Jan 20, 2023
91cd45f
Fix `Field.__eq__` to check all attributes
felixwang9817 Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def join_keys(self) -> List[str]:

@property
def schema(self) -> List[Field]:
return self.entity_columns + self.features
return list(set(self.entity_columns + self.features))
felixwang9817 marked this conversation as resolved.
Show resolved Hide resolved

def ensure_valid(self):
"""
Expand Down
6 changes: 5 additions & 1 deletion sdk/python/feast/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ class Field:
Attributes:
name: The name of the field.
dtype: The type of the field, such as string or float.
tags (optional): User-defined metadata in dictionary form.
description: A human-readable description.
tags: User-defined metadata in dictionary form.
"""

name: str
dtype: FeastType
description: str
tags: Dict[str, str]

def __init__(
Expand All @@ -51,6 +53,7 @@ def __init__(
Args:
name: The name of the field.
dtype: The type of the field, such as string or float.
description (optional): A human-readable description.
tags (optional): User-defined metadata in dictionary form.
"""
self.name = name
Expand All @@ -65,6 +68,7 @@ def __eq__(self, other):
if (
self.name != other.name
or self.dtype != other.dtype
or self.description != other.description
or self.tags != other.tags
):
return False
Expand Down