New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix feature service inference logic #3089

Merged

feast-ci-bot merged 11 commits into feast-dev:master from felixwang9817:fix_feature_service_inference

Aug 19, 2022

Collaborator

felixwang9817 commented Aug 16, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3075

felixwang9817 added 3 commits

August 16, 2022 00:36


          Add __init__.py files to allow test files to share names

1e09ad3

Signed-off-by: Felix Wang <[email protected]>


          Add feature service tests

5a5c6f6

Signed-off-by: Felix Wang <[email protected]>


          Fix feature service inference logic

07eaba6

Signed-off-by: Felix Wang <[email protected]>

feast-ci-bot added approved size/L labels

codecov-commenter commented Aug 16, 2022 •

edited

Loading

Codecov Report

Merging #3089 (31115ac) into master (9f221e6) will increase coverage by 8.73%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
+ Coverage   67.12%   75.86%   +8.73%     
==========================================
  Files         173      206      +33     
  Lines       15110    17142    +2032     
==========================================
+ Hits        10142    13004    +2862     
+ Misses       4968     4138     -830

Flag	Coverage Δ
integrationtests	`66.71% <22.91%> (-0.41%)`	⬇️
unittests	`58.30% <93.75%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_view_projection.py	`97.05% <ø> (ø)`
sdk/python/feast/errors.py	`69.88% <66.66%> (+2.25%)`	⬆️
sdk/python/feast/feature_service.py	`89.36% <73.33%> (+7.96%)`	⬆️
sdk/python/feast/base_feature_view.py	`80.00% <80.00%> (+0.45%)`	⬆️
...thon/tests/unit/infra/test_inference_unit_tests.py	`100.00% <100.00%> (+84.86%)`	⬆️
...sts/unit/local_feast_tests/test_feature_service.py	`100.00% <100.00%> (ø)`
...ra/materialization/batch_materialization_engine.py	`86.66% <0.00%> (-2.99%)`	⬇️
sdk/python/feast/feast_object.py	`100.00% <0.00%> (ø)`
.../contrib/postgres_offline_store/postgres_source.py	`50.66% <0.00%> (ø)`
.../feature_repos/universal/online_store/cassandra.py	`42.85% <0.00%> (ø)`
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

felixwang9817 added 2 commits

August 16, 2022 09:50


          Remove stray __init__.py file

51174b3

Signed-off-by: Felix Wang <[email protected]>


          Fix comments

45ec63c

Signed-off-by: Felix Wang <[email protected]>

adchia self-assigned this


          Add check

7a43b8f

Signed-off-by: Felix Wang <[email protected]>

achals reviewed

View reviewed changes

sdk/python/feast/feature_service.py Outdated

                                           if f.name in desired_features:
                                               projection.features.append(f)
                                   elif not projection.desired_features and projection.features:
-                                      # Second cass, so nothing needs to be done.
-                                      pass
+                                      # Second cass, so nothing needs to be done. In case something went wrong

Member

achals Aug 17, 2022

Suggested change

      
                                    # Second cass, so nothing needs to be done. In case something went wrong
          
                                    # Second case, so nothing needs to be done. In case something went wrong

adchia reviewed

View reviewed changes

sdk/python/feast/feature_service.py Outdated

-                                      desired_features = set(
-                                          feature_grouping.projection.desired_features
-                                      )
+                                  # There are three situations to be handled. First, the projection specifies

Collaborator

adchia Aug 17, 2022

Might be easier to read if you have the cases within the blocks themselves, instead of all in one block before the if starts

sdk/python/feast/feature_service.py Outdated

                                       for f in fvs_to_update[feature_grouping.name].features:
                                           if f.name in desired_features:
-                                              feature_grouping.projection.features.append(f)
+                                              projection.features.append(f)
+                                  elif not projection.desired_features and projection.features:

Collaborator

adchia Aug 17, 2022

would be cleaner imo if you had early returns instead of the elif and else.. and maybe some example definitions

e.g.

if projection.desired_features:
  # The projection wants to reference inferred features. Validate they exist
   # Example: FeatureService(features=[[fv_with_no_schema["feature]])
   ...
   return

if projection.features:
  # The projection only references features from a FV's known schema (not inferred). 
  # Example 1: FeatureService(features=[fv_with_schema[["feature"]])
  # Example 2: FeatureService(features=[fv_with_schema])
  return

# The projection wants all features from a FV that has an inferred schema
# Example: FeatureService(features=[fv_with_no_schema])
...

sdk/python/feast/feature_service.py Outdated

                                       for f in fvs_to_update[feature_grouping.name].features:
                                           if f.name in desired_features:
-                                              feature_grouping.projection.features.append(f)
+                                              projection.features.append(f)
+                                  elif not projection.desired_features and projection.features:

Collaborator

adchia Aug 17, 2022

wondering if we can exit earlier than this. i.e in line 98 instead

felixwang9817 added 3 commits

August 17, 2022 15:39


          Temp

40d7965

Signed-off-by: Felix Wang <[email protected]>


          Address comments

8dfb6db

Signed-off-by: Felix Wang <[email protected]>

Fix

c4d9c5a

Signed-off-by: Felix Wang <[email protected]>

adchia reviewed

View reviewed changes

sdk/python/feast/feature_service.py

+                              if projection.features:
+                                  # The projection has already selected features from a feature view with a
+                                  # known schema, so no action needs to be taken.
+                                  # Example: FeatureService(features=[fv[["existing_feature"]]]), where

Collaborator

adchia Aug 18, 2022

This also applies if the user is selecting from a fv with a known schema, but doesn't select features right?

adchia reviewed

View reviewed changes

sdk/python/feast/feature_service.py Show resolved Hide resolved

felixwang9817 added 2 commits

August 18, 2022 10:34


          Address comments

64dfdef

Signed-off-by: Felix Wang <[email protected]>

Fix

31115ac

Signed-off-by: Felix Wang <[email protected]>

adchia approved these changes

View reviewed changes

Collaborator

adchia left a comment

/lgtm

feast-ci-bot added the lgtm label

Collaborator

feast-ci-bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot merged commit 4310ed7 into feast-dev:master

kevjumba pushed a commit that referenced this pull request


          chore(release): release 0.24.0

c1c71da

# [0.24.0](v0.23.0...v0.24.0) (2022-08-25)

### Bug Fixes

* Check if on_demand_feature_views is an empty list rather than None for snowflake provider ([#3046](#3046)) ([9b05e65](9b05e65))
* FeatureStore.apply applies BatchFeatureView correctly ([#3098](#3098)) ([41be511](41be511))
* Fix Feast Java inconsistency with int64 serialization vs python ([#3031](#3031)) ([4bba787](4bba787))
* Fix feature service inference logic ([#3089](#3089)) ([4310ed7](4310ed7))
* Fix field mapping logic during feature inference ([#3067](#3067)) ([cdfa761](cdfa761))
* Fix incorrect on demand feature view diffing and improve Java tests ([#3074](#3074)) ([0702310](0702310))
* Fix Java helm charts to work with refactored logic. Fix FTS image ([#3105](#3105)) ([2b493e0](2b493e0))
* Fix on demand feature view output in feast plan + Web UI crash ([#3057](#3057)) ([bfae6ac](bfae6ac))
* Fix release workflow to release 0.24.0 ([#3138](#3138)) ([a69aaae](a69aaae))
* Fix Spark offline store type conversion to arrow ([#3071](#3071)) ([b26566d](b26566d))
* Fixing Web UI, which fails for the SQL registry ([#3028](#3028)) ([64603b6](64603b6))
* Force Snowflake Session to Timezone UTC ([#3083](#3083)) ([9f221e6](9f221e6))
* Make infer dummy entity join key idempotent ([#3115](#3115)) ([1f5b1e0](1f5b1e0))
* More explicit error messages ([#2708](#2708)) ([e4d7afd](e4d7afd))
* Parse inline data sources ([#3036](#3036)) ([c7ba370](c7ba370))
* Prevent overwriting existing file during `persist` ([#3088](#3088)) ([69af21f](69af21f))
* Register BatchFeatureView in feature repos correctly ([#3092](#3092)) ([b8e39ea](b8e39ea))
* Return an empty infra object from sql registry when it doesn't exist ([#3022](#3022)) ([8ba87d1](8ba87d1))
* Teardown tables for Snowflake Materialization testing ([#3106](#3106)) ([0a0c974](0a0c974))
* UI error when saved dataset is present in registry. ([#3124](#3124)) ([83cf753](83cf753))
* Update sql.py ([#3096](#3096)) ([2646a86](2646a86))
* Updated snowflake template ([#3130](#3130)) ([f0594e1](f0594e1))

### Features

* Add authentication option for snowflake connector ([#3039](#3039)) ([74c75f1](74c75f1))
* Add Cassandra/AstraDB online store contribution ([#2873](#2873)) ([feb6cb8](feb6cb8))
* Add Snowflake materialization engine ([#2948](#2948)) ([f3b522b](f3b522b))
* Adding saved dataset capabilities for Postgres  ([#3070](#3070)) ([d3253c3](d3253c3))
* Allow passing repo config path via flag ([#3077](#3077)) ([0d2d951](0d2d951))
* Contrib azure provider with synapse/mssql offline store and Azure registry store ([#3072](#3072)) ([9f7e557](9f7e557))
* Custom Docker image for Bytewax batch materialization ([#3099](#3099)) ([cdd1b07](cdd1b07))
* Feast AWS Athena offline store (again) ([#3044](#3044)) ([989ce08](989ce08))
* Implement spark offline store `offline_write_batch` method ([#3076](#3076)) ([5b0cc87](5b0cc87))
* Initial Bytewax materialization engine ([#2974](#2974)) ([55c61f9](55c61f9))
* Refactor feature server helm charts to allow passing feature_store.yaml in environment variables ([#3113](#3113)) ([85ee789](85ee789))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/L