Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add to_remote_storage method to RetrievalJob #2916

Merged
merged 2 commits into from
Jul 6, 2022
Merged

feat: Add to_remote_storage method to RetrievalJob #2916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dddebc
feat: Add to_remote_storage method to RetrievalJob
achals Jul 6, 2022
7532e64
docstring
achals Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions sdk/python/feast/infra/offline_stores/offline_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,26 @@ def metadata(self) -> Optional[RetrievalMetadata]:
"""
pass

def supports_remote_storage_export(self) -> bool:
"""
This method should return True if the RetrievalJob supports `to_remote_storage()`.
"""
return False

def to_remote_storage(self) -> List[str]:
achals marked this conversation as resolved.
Show resolved Hide resolved
"""
This method should export the result of this RetrievalJob to
remote storage (such as S3, GCS, HDFS, etc).
Implementations of this method should export the results as
achals marked this conversation as resolved.
Show resolved Hide resolved
multiple parquet files, each file sized appropriately
depending on how much data is being returned by the retrieval
job.

Returns:
A list of parquet file paths in remote storage.
"""
raise NotImplementedError()


class OfflineStore(ABC):
"""
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def get_expected_training_df(

@pytest.mark.integration
@pytest.mark.universal_offline_stores
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: f"full:{v}")
def test_historical_features(environment, universal_data_sources, full_feature_names):
store = environment.feature_store

Expand Down Expand Up @@ -410,7 +410,7 @@ def test_historical_features(environment, universal_data_sources, full_feature_n


@pytest.mark.integration
@pytest.mark.universal
@pytest.mark.universal_offline_stores
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
def test_historical_features_with_shared_batch_source(
environment, universal_data_sources, full_feature_names
Expand Down