-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert snowflake #2907
fix: Revert snowflake #2907
Conversation
This reverts commit f758f9e. Signed-off-by: Kevin Zhang <[email protected]>
This reverts commit 0ceb39c. Signed-off-by: Kevin Zhang <[email protected]>
5de2ed7
to
f63f8a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2907 +/- ##
===========================================
- Coverage 80.68% 59.31% -21.37%
===========================================
Files 178 177 -1
Lines 15837 15679 -158
===========================================
- Hits 12778 9300 -3478
- Misses 3059 6379 +3320
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Agreed #2903 shouldn't be reverted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
@sfc-gh-madkins I think the snowflake PR was merged in prematurely and we've decided to revert it first. I think there's some other issues that need to be addressed/ just general reviews from team members.
Please reopen the PR and give us a chance to do a more thorough review first!
Which issue(s) this PR fixes:
Fixes #