fix: Correctly generate projects-list.json when calling feast ui and using postgres as a source. #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for UI when using PostgreSQLSource. Adding name=self.name to to_proto() causes the projects-list.json to be generated correctly.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlexEijssen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AlexEijssen
changed the title
Fix for UI when using PostgreSQLSource. Adding name=self.name to to_proto() causes the projects-list.json to be generated correctly. Signed-off-by: alex.eijssen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR ensures the projects-list.json is generated correctly when calling feast ui and using Postgres as a data source, by adding name=self.name to to_proto(). It also adds description, tags and owner to the Postgres source which were previously missing.
Which issue(s) this PR fixes:
Fixes #2843