Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Install dependencies into a virtualenv for gitpod #2749

Merged
merged 9 commits into from
May 31, 2022

Conversation

achals
Copy link
Member

@achals achals commented May 31, 2022

What this PR does / why we need it:

When using prebuilds (which we are), only things in the /workspace/ directory are saved. But, by default gitpod's python environment is system-wide and installs into /home, which means that all installed dependencies are lost when the workspace actually starts.

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #2749 (2a85ee9) into master (3d2b431) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2749      +/-   ##
==========================================
- Coverage   80.27%   80.24%   -0.04%     
==========================================
  Files         169      169              
  Lines       14368    14366       -2     
==========================================
- Hits        11534    11528       -6     
- Misses       2834     2838       +4     
Flag Coverage Δ
integrationtests 70.45% <ø> (-0.37%) ⬇️
unittests 58.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.14% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2b431...2a85ee9. Read the comment docs.

achals added 9 commits May 31, 2022 17:26
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@pyalex
Copy link
Collaborator

pyalex commented May 31, 2022

/lgtm

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit de97bd3 into feast-dev:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants