Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use buildx for docker builds when changes merged into master #2703

Merged
merged 3 commits into from
May 16, 2022
Merged

ci: Use buildx for docker builds when changes merged into master #2703

merged 3 commits into from
May 16, 2022

Conversation

achals
Copy link
Member

@achals achals commented May 16, 2022

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

adchia
adchia approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022 •
edited
Loading

Codecov Report

Merging #2703 (35cf925) into master (1958df0) will not change coverage.
The diff coverage is n/a.

❗ Current head 35cf925 differs from pull request most recent head 39a6a7a. Consider uploading reports for the commit 39a6a7a to get more accurate results

@@           Coverage Diff           @@
##           master    #2703   +/-   ##
=======================================
  Coverage   58.66%   58.66%           
=======================================
  Files         166      166           
  Lines       13888    13888           
=======================================
  Hits         8148     8148           
  Misses       5740     5740
Flag Coverage Δ
unittests 58.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1958df0...39a6a7a. Read the comment docs.

@achals
buildx build smh
39a6a7a 
Signed-off-by: Achal Shah <[email protected]>
@achals achals merged commit 2d56963 into feast-dev:master May 16, 2022
@achals achals deleted the achal/fix-other-builds branch May 16, 2022 18:05
adchia pushed a commit that referenced this pull request May 16, 2022
@achals @adchia
ci: Use buildx for docker builds when changes merged into master (#2703)
232a77b 
* ci: Use buildx for docker builds when changes merged into master

Signed-off-by: Achal Shah <[email protected]>

* use --load to load the built image into docker

Signed-off-by: Achal Shah <[email protected]>

* buildx build smh

Signed-off-by: Achal Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achals @feast-ci-bot @codecov-commenter @adchia