ci: Make version bumping script more robust #2689
Conversation
Signed-off-by: Achal Shah <[email protected]>
| raise SystemExit(f"Could not find {VERSIONS_TO_BUMP} versions of {current_version} in {path_to_file_list}") | ||
|
|
||
| print(f"Found {versions_in_files} occurrences of {current_version} in files to bump {path_to_file_list}") | ||
| # The current version should be 0.18.0 or 0.19.0 or 0.20.0 etc |
There was a problem hiding this comment.
Don't think we need 0.18.0 or 0.19.0 right? Also after version bump we're at 0.21?
There was a problem hiding this comment.
Just as an example, but I'll update.
| with open(repo_root.joinpath(file_path), "r") as f: | ||
| file_contents = f.readlines() | ||
| for line in lines: | ||
| assert current_version in file_contents[int(line) - 1], f"File {file_path} line {line} didn't containe " \ |
Codecov Report
@@ Coverage Diff @@
## master #2689 +/- ##
===========================================
- Coverage 80.98% 58.53% -22.46%
===========================================
Files 166 166
Lines 13888 13832 -56
===========================================
- Hits 11247 8096 -3151
- Misses 2641 5736 +3095
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* ci: Make version bumping script more robust Signed-off-by: Achal Shah <[email protected]> * bump dockerfiles too Signed-off-by: Achal Shah <[email protected]> * fix build-docker-image Signed-off-by: Achal Shah <[email protected]> * use buildx instead of build in makefile Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah [email protected]
Running locally is smooth:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #