Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Assorted updates to feast packaging #2683

Merged
merged 6 commits into from
May 13, 2022

Conversation

achals
Copy link
Member

@achals achals commented May 13, 2022

https://packaging.python.org/en/latest/tutorials/packaging-projects/

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #2683 (4209a5a) into master (01d3568) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##           master    #2683   +/-   ##
=======================================
  Coverage   80.99%   81.00%           
=======================================
  Files         166      166           
  Lines       13872    13879    +7     
=======================================
+ Hits        11236    11242    +6     
- Misses       2636     2637    +1     
Flag Coverage Δ
integrationtests 71.53% <76.92%> (-0.23%) ⬇️
unittests 58.70% <84.61%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/version.py 80.00% <83.33%> (+8.57%) ⬆️
sdk/python/feast/__init__.py 92.59% <85.71%> (+1.28%) ⬆️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d3568...4209a5a. Read the comment docs.

achals added 2 commits May 13, 2022 12:17
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@adchia adchia self-assigned this May 13, 2022
@adchia adchia self-requested a review May 13, 2022 19:37
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Achal Shah <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label May 13, 2022
achals added 2 commits May 13, 2022 13:11
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 7c69f1c into feast-dev:master May 13, 2022
@achals achals deleted the achal/packaging-updates branch May 13, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants