Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete data sources from registry when using the diffing logic #2669

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: Delete data sources from registry when using the diffing logic #2669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/python/feast/diff/registry_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ def apply_diff_to_registry(
registry.delete_feature_view(
feature_view_obj.name, project, commit=False,
)
elif feast_object_diff.feast_object_type == FeastObjectType.DATA_SOURCE:
ds_obj = cast(DataSource, feast_object_diff.current_feast_object)
registry.delete_data_source(
ds_obj.name, project, commit=False,
)

if feast_object_diff.transition_type in [
TransitionType.CREATE,
Expand Down
1 change: 0 additions & 1 deletion sdk/python/feast/infra/offline_stores/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ def evaluate_historical_retrieval():
entity_df_event_timestamp_col
)

join_keys = []
all_join_keys = []

# Load feature view data from sources and join them incrementally
Expand Down