Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update new contrib plugins to include usage #2638

Merged
merged 1 commit into from
May 4, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented May 4, 2022

Signed-off-by: Danny Chiao [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@adchia adchia assigned achals and unassigned achals May 4, 2022
@adchia adchia requested a review from achals May 4, 2022 20:53
@adchia adchia changed the title [chore] Update new contrib plugins to include usage chore: Update new contrib plugins to include usage May 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #2638 (d31be88) into master (d59a91c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
- Coverage   80.65%   80.64%   -0.02%     
==========================================
  Files         163      163              
  Lines       13680    13727      +47     
==========================================
+ Hits        11034    11070      +36     
- Misses       2646     2657      +11     
Flag Coverage Δ
integrationtests 71.35% <ø> (-0.28%) ⬇️
unittests 58.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._stores/contrib/postgres_offline_store/postgres.py 35.13% <100.00%> (+1.80%) ⬆️
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <100.00%> (+2.56%) ⬆️
...thon/feast/infra/online_stores/contrib/postgres.py 32.69% <100.00%> (+2.69%) ⬆️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/tests/conftest.py 82.06% <0.00%> (-2.76%) ⬇️
sdk/python/feast/on_demand_feature_view.py 80.46% <0.00%> (-0.96%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️
sdk/python/feast/entity.py 89.87% <0.00%> (-0.54%) ⬇️
sdk/python/feast/inference.py 86.41% <0.00%> (-0.43%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59a91c...d31be88. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit f22430a into feast-dev:master May 4, 2022
@adchia adchia deleted the updateUsage branch July 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants