-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update DynamoDB BatchGetItem permissions #2542
docs: Update DynamoDB BatchGetItem permissions #2542
Conversation
Signed-off-by: Miguel Trejo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2542 +/- ##
===========================================
- Coverage 81.68% 57.63% -24.05%
===========================================
Files 141 140 -1
Lines 12000 11888 -112
===========================================
- Hits 9802 6852 -2950
- Misses 2198 5036 +2838
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only use batchget now, and never get? Or are there instance where we still use get?
@achals thanks for reviewing this yes, though if the user use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, TremaMiguel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Miguel Trejo [email protected]
What this PR does / why we need it:
DynamoDBOnlineStore
retrieve items calling theBatchGetItem
operation, documentation is updated for this.