Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update DynamoDB BatchGetItem permissions #2542

Merged

Conversation

TremaMiguel
Copy link
Member

Signed-off-by: Miguel Trejo [email protected]

What this PR does / why we need it:

DynamoDBOnlineStore retrieve items calling the BatchGetItem operation, documentation is updated for this.

@TremaMiguel TremaMiguel requested a review from a team as a code owner April 14, 2022 13:21
@TremaMiguel TremaMiguel requested review from kevjumba and removed request for a team April 14, 2022 13:21
@codecov-commenter
Copy link

Codecov Report

Merging #2542 (5a3c573) into master (fbdd5fc) will decrease coverage by 24.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2542       +/-   ##
===========================================
- Coverage   81.68%   57.63%   -24.05%     
===========================================
  Files         141      140        -1     
  Lines       12000    11888      -112     
===========================================
- Hits         9802     6852     -2950     
- Misses       2198     5036     +2838     
Flag Coverage Δ
integrationtests ?
unittests 57.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-80.00%) ⬇️
.../integration/online_store/test_universal_online.py 15.09% <0.00%> (-78.35%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.88% <0.00%> (-76.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-74.20%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-67.91%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 33.92% <0.00%> (-66.08%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdd5fc...5a3c573. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only use batchget now, and never get? Or are there instance where we still use get?

@TremaMiguel
Copy link
Member Author

@achals thanks for reviewing this

yes, though if the user use the DynamoDBTable class and calls _get_dynamodb_resource he can use that resource to do any available actions from boto dynamodb resource, including getItem.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, TremaMiguel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit bd4cb74 into feast-dev:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants