Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move storage configuration to serving #254

Merged
merged 6 commits into from
Oct 7, 2019

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Oct 6, 2019

Moving storage configuration from core so that we can alter serving configuration more dynamically.

  • Added RPC for serving to update core with its configuration
  • When changes are made to stores core will update the jobs accordingly
  • Serving reads store config from an external file, changes are hot-reloaded

TODO:

  • Code cleanup
  • Better testing at core
  • Make externalised config for serving optional (maybe)

Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

protos/feast/core/CoreService.proto Show resolved Hide resolved
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

@zhilingc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
unit-test-core 0fca98e link /test unit-test-core
unit-test-ingestion 0fca98e link /test unit-test-ingestion
unit-test-cli 0fca98e link /test unit-test-cli
unit-test-serving 0fca98e link /test unit-test-serving
unit-test-python-sdk 0fca98e link /test unit-test-python-sdk
integration-test 0fca98e link /test integration-test

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhilingc zhilingc merged commit 0fca98e into feast-dev:0.3-dev Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants