-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add support for push sources in feature views #2452
Conversation
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
+ Coverage 84.72% 84.85% +0.12%
==========================================
Files 126 127 +1
Lines 10798 10833 +35
==========================================
+ Hits 9149 9192 +43
+ Misses 1649 1641 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall - at some point we should add (a) docs for PushSource and (b) deprecation warning for write_to_online_store
, happy for those to be in future PR - up to you
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more nits
sdk/python/tests/integration/online_store/test_push_online_retrieval.py
Outdated
Show resolved
Hide resolved
sdk/python/tests/integration/online_store/test_push_online_retrieval.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Achal Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Part 2 after #2428
Which issue(s) this PR fixes:
Fixes #