Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename inputs parameter to sources for on demand feature views #2442

Merged
merged 7 commits into from
Mar 29, 2022
Merged

chore: Rename inputs parameter to sources for on demand feature views #2442

merged 7 commits into from
Mar 29, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR renames the inputs parameter to sources for odfvs.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner March 23, 2022 22:52
@felixwang9817 felixwang9817 requested review from kevjumba and removed request for a team March 23, 2022 22:52
@felixwang9817 felixwang9817 assigned achals and unassigned adchia Mar 23, 2022
@felixwang9817 felixwang9817 requested review from achals and removed request for kevjumba March 23, 2022 22:53
@felixwang9817 felixwang9817 changed the title refactor: Rename inputs parameter to sources for on demand feature views [WIP] refactor: Rename inputs parameter to sources for on demand feature views Mar 23, 2022
@felixwang9817
Copy link
Collaborator Author

there are some conflicts with Go, so I will hold this PR until #2429 is merged

achals
achals reviewed Mar 24, 2022
View reviewed changes
sdk/python/feast/go_server.py Outdated
from tenacity import retry, stop_after_attempt, stop_after_delay, wait_exponential

import feast
import grpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to delete the feast/grpc subdir

sdk/python/feast/on_demand_feature_view.py Outdated
elif isinstance(odfv_input, FeatureViewProjection):
self.input_feature_view_projections[input_ref] = odfv_input
if inputs and sources:
raise ValueError("At most one of `inputs` or `sources` can be specified.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, I would say one of 'sources' or 'inputs' and put sources first.

sdk/python/feast/on_demand_feature_view.py Outdated
Comment on lines 74 to 75
inputs: Optional[
Dict[str, Union[FeatureView, FeatureViewProjection, RequestDataSource]]
] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making this a kwarg from an arg is a backwards incompatibile change. e.g.

ODFV(
  "my name",
  [...],
  {"input1": some_feature_view}
)

will no longer be valid. Are you thinking that this is okay because it's experimental?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordering parameters so that this doesn't break

@felixwang9817 felixwang9817 changed the title [WIP] refactor: Rename inputs parameter to sources for on demand feature views refactor: Rename inputs parameter to sources for on demand feature views Mar 25, 2022
@felixwang9817 felixwang9817 changed the title refactor: Rename inputs parameter to sources for on demand feature views chore: Rename inputs parameter to sources for on demand feature views Mar 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #2442 (18ca377) into master (5352ce7) will increase coverage by 0.02%.
The diff coverage is 60.46%.

@@            Coverage Diff             @@
##           master    #2442      +/-   ##
==========================================
+ Coverage   58.45%   58.47%   +0.02%     
==========================================
  Files         126      126              
  Lines       10780    10789       +9     
==========================================
+ Hits         6301     6309       +8     
- Misses       4479     4480       +1
Flag Coverage Δ
unittests 58.47% <60.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 38.24% <0.00%> (ø)
sdk/python/feast/feature_store.py 70.13% <0.00%> (ø)
...tegration/feature_repos/universal/feature_views.py 36.92% <ø> (ø)
...n/tests/integration/registration/test_inference.py 85.47% <ø> (ø)
...on/tests/integration/registration/test_registry.py 62.30% <ø> (ø)
sdk/python/feast/on_demand_feature_view.py 70.12% <65.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5352ce7...18ca377. Read the comment docs.

@felixwang9817
Rename inputs parameter to sources for odfv
7c6221d 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Address CR comments
e47449c 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Fix Go references to ODFV proto
d966787 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Fix tests
dbafedd 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Fix Java
05b393e 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Fix Java again
1b9d808 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
Fix Python integration tests
18ca377 
Signed-off-by: Felix Wang <[email protected]>
achals
achals approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit c4adf80 into feast-dev:master Mar 29, 2022
jbvaningen pushed a commit to jbvaningen/feast that referenced this pull request Mar 30, 2022
@felixwang9817
chore: Rename inputs parameter to sources for on demand feature views (…
093d655 
…feast-dev#2442)

* Rename `inputs` parameter to `sources` for odfv

Signed-off-by: Felix Wang <[email protected]>

* Address CR comments

Signed-off-by: Felix Wang <[email protected]>

* Fix Go references to ODFV proto

Signed-off-by: Felix Wang <[email protected]>

* Fix tests

Signed-off-by: Felix Wang <[email protected]>

* Fix Java

Signed-off-by: Felix Wang <[email protected]>

* Fix Java again

Signed-off-by: Felix Wang <[email protected]>

* Fix Python integration tests

Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: joostvan <[email protected]>
@achals achals mentioned this pull request Mar 30, 2022
Merged
@felixwang9817 felixwang9817 mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felixwang9817 @codecov-commenter @feast-ci-bot @achals @adchia